search

jpcima / ysfx

Hosting library for JSFX
Apache License 2.0
179 stars 27 forks source link

Hangs on autopeakfilter (FFT Peak-Following Filter) #66

Closed AnClark closed 1 month ago

AnClark commented 2 years ago

Hi, Jean.

I'm testing ysfx in REAPER on Linux, however it may hang on several JSFX files. For example, FFT Peak-Following Filter (autopeakfilter) shipped with REAPER (~/.config/REAPER/effects/filters/autopeakfilter).

How to reproduce this issue:

  1. Add a track, load ysfx, then load "autopeakfilter"
  2. Bypass ysfx
  3. Load a media file into the track (WavPack, 44100Hz, 24bit integer)
  4. Play
  5. De-bypass ysfx, then REAPER will hang right now

My environment:

junh1024 commented 9 months ago

I think ysfx will hang/choke eventually on all JSFX which use FFT. Including my own FFT FX & included FFT FX like "schwa/fft_splitter" . MDCT doesn't hang, but it doesn't seem to effect the audio.

It would be nice to have FFT & MDCT working in YSFX as all the interesting FX are FFT/MDCT.

Tested on:

junh1024 commented 1 month ago

Hey Dude, Joep's fork of YSFX has seemingly fixed the FFT bug. Try this:

https://github.com/JoepVanlier/ysfx/releases

AnClark commented 1 month ago

Hey Dude, Joep's fork of YSFX has seemingly fixed the FFT bug. Try this:

https://github.com/JoepVanlier/ysfx/releases

Thanks a lot! I'll give it a try.