jpcompartir / LandscapeRGolem

playing_with_golem_learning
Other
0 stars 0 forks source link

Fix over time charts #33

Closed jpcompartir closed 1 year ago

jpcompartir commented 1 year ago

Add fixes for https://github.com/jpcompartir/LandscaperGolem/issues/32

Summary:

move dateRangeInputs to a module - reduce duplication + better debugging - at the cost of a bit of NS() trickiness. call the module from each of the tabs that have over time charts with dateRangeInputs/updateDateRangeInputs filter the data frame inside these modules and return the module for the parent module to access that data

Still not sure on what changed to lead to the breaking changes, but this fix is better than original implementation.