[TODO] Audit: Sundry Loose ends to tidy up or dismiss

[jpcsupplies]

There are various notes and todo tasks commented in code we probably forgot about. Some are probably so old we already did them or forgot what they are for.. oops!

Just listing them below.

• General: remove comments that are no longer relevant
• Accountmanager: discriminate between npc/markets better to cater for player markets not just npcs.
• Accountmanager: scheduler routines (is this needed? we can just run the check on server reboot)
• Accountmanager purge logic - an admin configurable option to set length of expiry
• Accountmanager purge logic - how to treat expired faction members - who gets assets etc #56
• Econdatamanager: #98 When creating a new price table, can we make it so we only need the ore prices, and use them with the build cost table built in modapi to tally the components costs. eg 1 ingot = 100 ore. 100 ore is worth 5 credits. So 1 ingot is worth 5. 1 plate has 20 ingots, so 1 plate is worth 20 times 5 (so value is 100), 1 metal grid has 50 plates, so 1 grid is worth 50 times 100 (5000) etc etc this would only apply when creating a new table, existing tables would work the same as they do now.
• Market manager: Gas handling (this may be superseded by the refueling ENH #111 )
• Econconfigstruct: Making all options available to admins to configure in game per #88
• In general econconst - need a way to stimulate economy where players are not active buying or selling and/or npc keeps running out of cash (may be superseded by player markets or ambient traders)
• marketstruct: is this going to be flexible enough to cover offers system, npcs markets, and player/faction managed markets? (going by orderbook struct I am going to say yes)
• lcdmanager: projected ships?
• lcdmanager: multi market - show cheapest in range item in stock to buy from market, and most expensive sell to market price in range with stock ?? Should we contemplate offers too ?
• lcdmanager: component and tool alignment (decimal places)
• lcdmanager: debug code is still active
• setextbuilder/textpanelwrite: seems to have some duplicated code.. is this intentional?
• messagebase: todo here about send error to server and admin
• messagebuy:todos about cryos, dead players , find best market not blacklisted
• messagebuy todo about trade blocks and cargo inventories (i think you got most of that done except trade block)
• messagebuy: Todo notes about admin checks on afford..
• messagebuy: todos on offer system
• messagebuy: TODOs: handling of players who recently got disconnected before concluding trade.
• messageclienttextmessage: updating balance on hud if payment received notification
• messageconnectionrequest: todo respond to communication version issues
• messageconnectionresponce: sundry notes on assigning or advancing missions
• messagecontainer: its a workaround ? (sounds like its a trap! star wars ha!)
• messagelistaccounts: column headings footnote, and todo on #54
• messagemarketitemvalue: todo qty range checking? (what was our thinking here? only display in range markets - i think it does already?)
• messagemarketmanagenpc: todo: move command. (also does deleting market delete the stock? should it transfer to another market?)
• messagemarketpricelist: todo combine multiple markets to a single coherent price list, todo: format number/currency name
• pizza: what is your favourite ;o)
• messagepayuser: various sundry comments - If a user is paid while offline, send them a faction chat message indicating why they were paid?
• messagesell todos on trade block etc same as message buy, offers etc
• messageset - is this doing everything inventory related we need?
• messageupdateclient: todo about hud
• connectionhelper todo about exception details
• economyscript - hourly market processing, various notes and todos, accounts command not keeping it open; entire news system unfisnished
• support : assisted demo code comments
• Airstrikes: they cost extra ;o)

[jpcsupplies]

(i wrote this while frequently falling asleep on keyboard so apologies.. !)

[jpcsupplies]

• purge logic Wish list - "tidy up" - if all faction members roll over the idle purge time limit can we simply delete their faction entirely?

[jpcsupplies]

• economy script: todo: hud customisation: need to add some clientconfig.globals somewhere for the if checks below
• todo: hud command: need option to show or hide individual elements see region "hud display" //eg cargo, faction, trade zone, contract/mission/subsidy count, balance?
• messageclienttextmessages: Process client: //todo: need this to update balance on their HUD too

[jpcsupplies]

This list is now out of date