jpcsupplies
commented
8 years ago Long version of meeting of the Blue Mining Board last night lol - Incorporating the "accept/deny" logic of #35 if possible to avoid doubling up similar logic - (messageofferpay or something along those lines) If we use this from our wiki:
- Database: Order Book
- Purpose: Records all items for sale or wanted to buy by players, and the offer price, Optionally refer to the station which is selling the goods at this price (for elite style trading functionality) This could be replaced by simply creating an Order book for each station also.
- Content:
- UID of seller, Product ID, Sell, Quantity, Sell Price, Optional ID of trade station
- UID of buyer, Product ID, Buy, Quantity, Desired Buy Price, Optional ID of trade station
- Notes: Orderbook could also contain a qty filled/sold field, but shouldn't be needed as the figure drops as each sale is made.
And alter it as follows:
- UID of seller, Product ID, Sell, Quantity, Sell Price, timeout, Optional ID of trade territory or player
- UID of buyer, Product ID, Buy, Quantity, Desired Buy Price, timeout, Optional ID of trade territory or player
When a player A sells directly to another player B: Write UID of player A to "Steam ID of Seller" Write the product ID being offered to "Product ID" Write flag "Sell" to "Sell" (We can also have other flags like offer, frozen etc) Write the amount to "Quantity" (and deduct that from seller inventory) Write Offer price to "Sell Price" Write our default timout to "timeout" - start clock Write the (confirmed) steam Id or nickname to "Optional ID of trade territory or player" (ID probably better)
Send a notification to Player B screen indicating "they have received an offer from Player A to sell qty X at price Y - type /sell accept to accept offer" (or /sell deny to reject and return ore to seller)
Because the "Order Book" table is also used by station/territory to player trade the player can accept the offer two ways: 1: /sell accept 2: When we implement "registered trade territories" or faction trade the sale will show in their personal market list too - so they can also use /buy qty item price player if they only want to partially accept that price from that player for a partial amount.
Notes:
- The timer can also be used to time limit offers posted to order book later on?
- If there is no time limit (such as an on-going offer in their registered trade market) timer is -1 this will also apply if we use a timestamp instead of a timeout number
- Timeout could also be a time stamp compared to server clock (this means timestamp needs to be generated based on server side)
- we could add a /sell extend to add another 2 minutes or similar amount. the extend command should not accept any parameter to prevent them exploiting it to "lock in" the sale so the player cant get it back
- the seller can do /sell cancel to return the remaining qty to his inventory
- If he is offline after the time runs out - alter their order book record to something like "ON HOLD" so nobody else can buy the goods, and they are automatically returned to his inventory on logging in again?
- when partial sales are made, we simply deduct the qty from the record in the order book, and increase/decrese buyer/seller money as appropriate, and add the goods to buyer inventory or overflow drops at their feet.
- This architecture also eliminates the need for "queuing offers" as they all just write to the order book and all have their own timer.
- The /sell accept command may require a nickname parameter to discriminate between multiple offers
- We may need to move the /sell accept command to an /accept command to allow reuse under issue #35
- When territorial trade is enabled their price book is automatically filtered to only show buys/sells for that territory, we use the territory field similarly here only it is a player ID - this will be the same logic for non-faction "traders" thus why method 2 above will work as well later.
- This is basically the same logic as "territorial trade" or "faction trade" except in their case you would specify the territory name (either automatically in the case of GPS range checks, or manually by specifying a name of a player/faction/trade territory)
midspace
Need to be able to sell (offer) goods to another player for a unit price.
the other player should get a confirmation prompt and trigger a timer. if they /sell accept they buy the goods - (if they lack inventory space it falls to their feet ? requiring a collector)
if they /sell deny they dont buy the goods, or if a preset timer (eg 2 minutes) runs out
if the seller /sell cancels prior to the buyer responding it immediately ends the timer and cancels the sell offer
This requires some sort of confirmation system to work..
should work similarly to selling to an npc