search

jpcsupplies / Economy_mod

Basic Economy System for Space Engineers
13 stars 12 forks source link

ENH: Minor irritation - invalid commands echo back still #9

Closed jpcsupplies closed 9 years ago

jpcsupplies commented 9 years ago

Ha! same issue midspace had; purely aesthetic so low priority - When commands are used correctly they dont echo back (correct!) BUT when commands are used incorrectly or with invalid options, they still echo back.

I probably need to add an if statement wrapping the entire command section in a check if the player typed a "/" at the start of the line, and return true if they did to suppress it..

What really concerns me here is tho, will this prevent other scripts from getting their commands correctly? or is the suppression purely aesthetic, and the server still processes it to the other scripts, even without the echo back. Before I add said wrapper I should find the answer to this question out.

jpcsupplies commented 9 years ago

Changing this to an ENH, since it doesnt functionally hurt anything; and it may become a bug if we try to fix it unnecessarily. I suspect the answer here is adding the / check to all commands we support, and ignore it (allow it to still echo) if its not one of our commands and let other scripts worry about it.

jpcsupplies commented 9 years ago

looks like we have return trues and falses mostly in the right places - and it doesnt really hurt the program flow anyway..