Open ansinerd opened 1 year ago
I do notice on a experimental version of provenance which is porting play to their app doesn’t have same issue play has on Vulkan so I wonder if there is some type of moltenvk (maybe different versions?) problem here. For opengles I think I’m getting similar regressions too including some hitching in games like KingdomHearts.
Do you have examples of games that have regressed over time?
I'm aware of the KH issues on OpenGL/iOS, working on a fix.
Thanks!
Do you have examples of games that have regressed over time?
I'm aware of the KH issues on OpenGL/iOS, working on a fix.
Thanks!
Yeah I'm mentioning via Vulkan side of things. Idk why a port of play and offical app working differently on same Vulkan without editing other than moltenvk differences. Some of us talking about it in the discord too. Play app.
Provenance port
The main issue with Vulkan on Apple GPUs is that MoltenVK doesn't properly support framebuffer fetch (https://github.com/KhronosGroup/MoltenVK/issues/1374). I have a patch that adds support for it, but it probably breaks other stuff (namely fragment shader interlock on Intel GPUs).
And that second screen shot you uploaded looks suspiciously a lot like OpenGL. Here's a screen shot of OpenGL running on macOS (Apple M1):
The main issue with Vulkan on Apple GPUs is that MoltenVK doesn't properly support framebuffer fetch (https://github.com/KhronosGroup/MoltenVK/issues/1374). I have a patch that adds support for it, but it probably breaks other stuff (namely fragment shader interlock on Intel GPUs).
And that second screen shot you uploaded looks suspiciously a lot like OpenGL. Here's a screen shot of OpenGL running on macOS (Apple M1):
Hm they said it was running Vulkan it's still being ported so I'll have to show them your message see if it's a mistake. Thanks also sorry you got bothered by comparing a port just wondered if it was a moltenvk difference or not. I’ll keep you posted.
Do you have examples of games that have regressed over time?
I'm aware of the KH issues on OpenGL/iOS, working on a fix.
Thanks!
I don’t know if i mentioned some games that were not part of compatibility list but I mentioned my own experience with these games which i tried on earlier build (june/july) and then now on latest.
I am sorry in advance if i am causing you trouble. and once again even to be able to play our childhood games on our iPhone/iPad is nothing but a miracle. Thank you so much for your immense efforts and time. Wish you best of luck and we hope in months we could see more improvement to sound and graphics. Thanks once again.
The main issue with Vulkan on Apple GPUs is that MoltenVK doesn't properly support framebuffer fetch (KhronosGroup/MoltenVK#1374). I have a patch that adds support for it, but it probably breaks other stuff (namely fragment shader interlock on Intel GPUs).
And that second screen shot you uploaded looks suspiciously a lot like OpenGL. Here's a screen shot of OpenGL running on macOS (Apple M1):
Can we #ifdef this?
If you want, I can take a look at the patch and make a PR.
Everyone is really excited about Play! in Provenance so whatever I can do to help lmk.
This is the patch, dunno if it still applies cleanly since I made that last year: https://github.com/jpd002/MoltenVK/commit/898553af81e3ee24e82d5c654c15776c3c1b4b78.
I don't think the MoltenVK team would accept this patch as is. I think maybe adding a special flag in a forked MoltenVK version to enable this on iOS would be possible, but it's painful to maintain. There might be other options :)
This is the patch, dunno if it still applies cleanly since I made that last year: jpd002/MoltenVK@898553a.
I don't think the MoltenVK team would accept this patch as is. I think maybe adding a special flag in a forked MoltenVK version to enable this on iOS would be possible, but it's painful to maintain. There might be other options :)
Interesting, I'll take a look.
We would need this for Citra too I think, which I'm working on a fork based on an android arm64 fork.
I was able to merge that patch no issues.
Added for here, https://github.com/Provenance-Emu/MoltenVK
I'm not building MoltenVK from source yet, but will change over and test this eventually
This is the patch, dunno if it still applies cleanly since I made that last year: jpd002/MoltenVK@898553a.
I don't think the MoltenVK team would accept this patch as is. I think maybe adding a special flag in a forked MoltenVK version to enable this on iOS would be possible, but it's painful to maintain. There might be other options :)
Whatever you did in recent most commit on github has improved the performance of some games. Game : Urban Reign Fps : upto 37 now whereas it used to be 15-20fps earlier Although vertical line issue still persists. Video backend : OpenGL
Video backend : experimental Vulkan Game : Urban reign Fps : upto 56 fps achieved The vulkan backend has done some magic, I remember in earlier build game wont even boot on Vulkan. Then on last few builds game would run slower than open GL and now game can easily play between 40 to 56fos constantly.
Issue : visual graphic glitch that keeps on happening throughout the game. As seen in screenshot below.
request : if only vulkan graphical glitch is fixed this game will become perfectly playable at full speed on VULKAN backend. On open GL vertical line plus dropping fps needs to be fixed.
once again, massive gratitude for your work. Amazing amazing work indeed. Great performance in recent build. I am so happy and glad to see play ! Getting where we all wish to see it.
2 : I know GOW II is not marked playable but i did try it on recent most github build. Cut scenes render perfectly upto 30 fps on openGL 1x resolution but same green screen issue once game starts. On Vulkan backend : the game plays at 14-15 fps constantly but there are graphical glitches all over. If Vulkan is fixed and even 5fps is increased, game would be playable imo. Attaching screenshot below , from cut scene on openGL with 32fps and Vulkan on 14fps with graphical glitch.
PS : Pardon me for writing in not so well formed manner. I am not intending to bother you Jpd or demand anything, all we wish is to improve this great emulator and I feel I can contribute this way by reporting issues I am facing so that i could be fixed. thanks once again for being kind and patient. Lastly, thank you so much for even making it a possibility for all of us to play ps2 games on iOS.
Continuing this thread to have your attention dear dev.
we all are grateful to you for your wonderful work on play ! Emulator, its something that we have been expecting to deliver amazing performance one day. One of a quite HLE emu.
anyways, I was hoping to know if it was possible for you to improvise Vulkan support for android and ios devices.
the Dolphin emu is completely metal supported now, it has improved the performance much.
Because of Vulkan, now we have an amazing and ever refining CITRA port for ios. Vulkan has sped up the emulation on iOS as well as on pc with pcsx2 and yuzu.
even on Play ! Emulator, many games run faster on Vulkan backend but with more and more graphical glitches compared to opengl backend. Assuming Vulkan offers better experience, could we expect you to try you hacky patch or workaround you mentioned before on ios/android and try and improve the emulation on those devices specifically even if no pc.
so it’s kind of request to keep in mind that we would be grateful if Vulkan is improved in play ! I genuinely wanna use Play ! On my secondary android device but even with good specs the performance is not really great on android. Not comparing any other emulator, because we have been supporting and wanting play ! To be no 1 choice for pcsx2, so was hoping if you could do anything for vulkan refinement on all devices (specifically phones/ipad)
thank you so much in advance
First of all we are indebted to you for your amazing work. Thankful to you for making play ! A possibility on ios. I just wanted to request some ios related improvement, past few updates the open GL performance has regressed with time. Many games that used to work slightly better have regressed. Vulcan is hit or miss like before. I know you are independent developer and your work is highly appreciated, its not a demand but rather a polite request if u could some ios related improvement to your amazing emulator to make it more playable.
thank you
System Details