search

jpd002 / Play-

Play! - PlayStation2 Emulator
http://purei.org
Other
2.11k stars 254 forks source link

[Android][BUG]Wrong Cover #240

Closed acocalypso closed 9 years ago

acocalypso commented 9 years ago

I tried latest weekly and figured out that I have some wrong Covers for .elf files For fire.elf Im getting the image of the Fire Heroes game and for the quake homebrew .elf Im getting the Quake III Cover.

Is there a possibility to check for the game ID

Zer0xFF commented 9 years ago

That's because it's using the file name.

Unfortunately that has it limits, I'm currently working on a method to use game ID instead.

But for elf, I don't imagine you'd ever be able to get a cover since the elf itself tends to be the ID.

Edit: and as you probably also know there isn't a real way to attempt to get cover for a homebrew.

acocalypso commented 9 years ago

I can send a prove if you want to Am 20.07.2015 4:00 nachm. schrieb Thunder07 notifications@github.com:That's because it's using the file name.

Unfortunately that has it limits, I'm currently working on a method to use game ID instead.

But for elf, I don't imagine you'd ever be able to get a cover since the elf itself tends to be the ID.

—Reply to this email directly or view it on GitHub.

Zer0xFF commented 9 years ago

There is no need, The Issue is know, I for one am getting a picture of NCAA Final Four 2001 for Final Fantasy Type 0 (a psp game :p)

LinkofHyrule89 commented 9 years ago

@jpd002 is working on a method to pull the game ids from the games Wren the app starts so that can be used for the search instead however if you have working cover for that feel free to submit a pull request we appreciate any help from other developers.

Zer0xFF commented 9 years ago

@LinkofHyrule89 a pull request why?
There currently isn't a method to load a custom cover nor if there was will the cover be made part of the app itself, thus no need for any pull requests.

Edit: also, it seems your replying to acocalypso, if so then what I've said above.... if you're referring to me, my method doesn't get the serial number only uses it(the serial) to get the cover, so I'd still need @jpd002 method to get the serial in the 1st place.

LinkofHyrule89 commented 9 years ago

Sorry for the confusion I was replying to @acocalypso because he said he was working on a way to get the game id.

Zer0xFF commented 9 years ago

@LinkofHyrule89 I think you're still confused, I think your read his quotation of me saying I'm working on a way :p

acocalypso commented 9 years ago

no im not working on a possible fix for that :D

LinkofHyrule89 commented 9 years ago

Oh OK lol that makes sense.

jpd002 commented 9 years ago

That's been fixed in the previous weekly build (2015-07-26) which has largely improved game detection.