AbandonedCart
commented
8 years ago According to your code if it is the wrong file extension (!IsLoadableExecutableFileName(images.getName())), but the game ID is null (NativeInterop.GetDiskId(images.toString()) == null) it will be removed from the list. Since that is done after the full list is already generated, it will run through an irrelevant search.
Was there something wrong with the method I had added yesterday (https://github.com/AbandonedCart/Play-/commit/cd310b93999d3b0c68024785a81dab498871011e)?
Zer0xFF
LinkofHyrule89
jpd002
hehe, I was hoping this would overwrite the other pull request.
anyway, this contains all of my push with added list filtering (it won't list an image(elfs too), unless they're valid).
1) Covers are saved (much faster loading on the next run and needs no connection) 2) using the serial no, compared against db, I can find name and id (thegamedb ID) using that ID I can request the cover from thegamedb, yielding more accurate results. (when serial is not matched, thus ID is missing, we'll still attempt to get cover using name) 3) save game description too.(this is done the 1st time the image is loaded, or preview opened) 4) parse thegamedb to sql and cross match for serials. 5)Clean the code a bit more, there is alot of redundant functions, since I've used/recycled some of @LoungeKatt and also made my own, the re-adapted each to work together, I just pushed this to show progress 6) filter invalid disk images.
Note: this won't compile before you finish adding DiskUtils GetDiskId, my implementation assumed the null method(can be changed if you decide with exception method, but if you look at it as it stands, it makes more sense returning null), I've also kept the I capital to match with function tryGetDiskId.
Also, you should return the serial as is without the ;1 (e.g SLES_XXX.XX), again all of that could be adjusted for, but since the db is this way, it's just more convenient (also milliseconds faster :P ).
There are still few things I'd like to do, but that would be for a future pull, 0) restructure the code (it works perfectly as is, but definitely could be better) 1) the current db will only match 1119 out of the 1600 (note each ID contains multiple serials for different rejions), I can match around an extra 250 with 90% accuracy, however, I'd like to them and the remaining manually, to make sure 100% of their accuracy. 2) place a cross-matched db, instead doing it on the phone, @LoungeKatt has done that but his implimenation is different than mine. 3) add cover clearing option. (@LoungeKatt has done that already) 4) allow user to choose own cover. 5) fuzzy search (won't really be needed once I'm done cross-matching the entire db)