jpd002 / Play-

Play! - PlayStation2 Emulator
http://purei.org
Other
2.04k stars 248 forks source link

Save Game Cover To Device #261

Closed adriandennis17 closed 8 years ago

adriandennis17 commented 8 years ago

it seems with each launch of Play! it downloads the game cover wouldn't it be more efficient, when a cover is downloaded its save to the device..and is in a way sync to the game..so the game will use the cover on the device instead of downloading again..and if the game should be deleted the cover will automatically be deleted.

Zer0xFF commented 8 years ago

That's already been covered. If I'm not mistaken the weekly is out? If so it's also been released.

adriandennis17 commented 8 years ago

oh..so does it also saves the game info ?

Zer0xFF commented 8 years ago

Yes

adriandennis17 commented 8 years ago

just tested it..doesn't seem to save the info..

AbandonedCart commented 8 years ago

Just tested what? Make sure to make a clean build from the current source, otherwise it won't save the info because the feature wasn't integrated yet.

adriandennis17 commented 8 years ago

I'm talking the info about the game's you might have..if your connected to the net..you can get the info about the game..but if your offline it doesn't show.

AbandonedCart commented 8 years ago

What is it with everyone explaining the obvious part of the statement, lol. What did you test? Was it the weekly build, a recent compile, or your toaster oven?

Zer0xFF commented 8 years ago

@adriandennis17 I said if weekly is out..

adriandennis17 commented 8 years ago

@loungeKatt...😓

What i test: Game info..if you should highlight a game you will see the info about the game..it should also be available offline as @Thunder07 pointed out..but it's not showing while offline..

Build Tested On: 07/26/2015

Zer0xFF commented 8 years ago

I'm guessing you switched of your net to test that?

adriandennis17 commented 8 years ago

@Thunder07 Yes, the game cover are now fetching from device..but game info is not available offline..

Zer0xFF commented 8 years ago

Hehe your right, description is not showing, although it's being saved, I forgot to actually load it or something.

@LoungeKatt commit probably already dealt with that?

adriandennis17 commented 8 years ago

also for .elf files

when i highlight it to get info, it crashes the app

for .elf why not use one cover for (i made one if you want 😆) or you can use the new Play! icon

and since there's no database for getting an elf file info and there's no way of reading the info from the file...just give one info for elfs..stating what a elf is... game or app homebrew etc

LinkofHyrule89 commented 8 years ago

I'm sure this is covered but if it doesn't have info pulled it crashes. Small suggestion eventually there needs to be something that tells people long holding on a game will bring up the info. I didn't even know this function existed. Second suggestion would be whenever the Android TV UI is made you could probably just have it display the info when the game is selected instead of a long hold. Anyways that's awesome it shows the info now keep up the good work.

jpd002 commented 8 years ago

I've updated the weekly build to include @LoungeKatt's changes which improve many things with the file picker interface: http://purei.org/downloads/play/weekly/Play-20150726.apk

adriandennis17 commented 8 years ago

@jpd002 i just tested that build from the link you post..

but it crashes if you try to launch while offline..

and if you should connect to the net and launch it works and while in the app disconnect from the net everything works but closing the app and then opening it again it crashes again.

AbandonedCart commented 8 years ago

https://github.com/jpd002/Play-/pull/262

jpd002 commented 8 years ago

Will be in Sunday's weekly build (2015-08-02).

adriandennis17 commented 8 years ago

Okay, will close issue.