jpd002 / PlayServices

1 stars 1 forks source link

Invalid Links while building #1

Open Zer0xFF opened 6 years ago

Zer0xFF commented 6 years ago

this issue belongs here, right? someone on GPlus reported getting invalid links while trying to access automated build. !IMAGE thats because the current method doesn't discriminate between different build, so the minute the Win32 build (as an example) is available the download links for all the other platforms will be updated, and since Android takes the longest build this can happen.

I think Ideally, you'd keep a list of the builds and display the last complete build. use can use hooks in travis for that.

this was something I tried a while back, except that I build a list based on the amazon xml then keep track of commit for details, again, this cab be readapted to instead of checking with amazon on every page run, to check the database only, and to update it, you can use hooks from travis to notify it of updates Live demo & Code

jpd002 commented 6 years ago

Yup, this belongs here! 👍

I'm relying on the build status of GitHub's commit: https://github.com/jpd002/PlayServices/blob/master/server/endpoint_builds.php#L81. I thought that meant that all checks for that particular commit were complete. I thought "success" meant that all builds for that commit were complete, but maybe I was mistaken?

I agree that a list of builds would be better. I think that would fit in PlayServices, but we would just need to find the best way to do so. I guess the current API to get builds could be improved to add support for multiple builds.

This is still an experiment and I'm not quite set on the technological choice. While I like PHP, I don't know if it's the best language to use to start a project like this one from scratch. I was looking at dotnet core and I'm leaning towards that right now, but I'm still undecided.

Zer0xFF commented 6 years ago

ummm, well I'm making the assumption that the slow build is the cause, as the only way I can make sense of it, it could be something else as well :/

but yes, I'd also assume if you're getting the "success" message from GitHub itself it would refer to all the builds, unless somehow it's returning the 1st result it gets aka appvoyer?

if you're building a list, a travis web hook is better, that way travis itself would call your update script with the necessary info.

I really don't know much about dotnet so I can't comment, but I know a thing or 2 about php (though I'd say the code above was a quick job, so it could be improved), but I'm not sure why you can't used PHP.

edit: just tried a quick test, the status "seems" to only updates to success when both builds succeeded (note, due to appvoyer upload, i always get a reported fail), but if any of the builds fail, then the status is updated to fail immediately.