jpd236 / kotwords

Collection of crossword puzzle file format converters and other utilities, written in Kotlin.
Apache License 2.0
25 stars 6 forks source link

Allow for non-zipped JPZ #25

Closed boisvert42 closed 2 years ago

boisvert42 commented 2 years ago

My workflow when using kotwords is invariably: 1) download JPZ 2) unzip JPZ 3) reformat XML to make it pretty-printed. It would be wonderful if I could skip steps (2) and (3).

jpd236 commented 2 years ago

Exporting formatted XML is probably a reasonable default. If the file is zipped by default, the extra whitespace won't make much of a difference (not that it makes much of a difference when unzipped either).

I still feel like zipping is a better default; for certain JPZs it makes a decent size difference. But an advanced setting to leave the export uncompressed would be fine with me.

jpd236 commented 2 years ago

All forms now have a "Compress JPZ file" option, which is checked by default.

When checked, the output is the exact same as before - compressed, unformatted JPZ. The assumption here is that if you want to compress the output, you don't care about modifying the contents, so there's not much reason to pretty-print it.

When unchecked, the output is a pretty-printed XML file, with no ZIP compression, so you can view it and tweak it as desired.

I think that should cover this, but let me know if there's anything else that would be useful here!

boisvert42 commented 2 years ago

Thanks!