search

jpd236 / kotwords

Collection of crossword puzzle file format converters and other utilities, written in Kotlin.
Apache License 2.0
25 stars 6 forks source link

Support missing bylines for WSJ #37

Closed oeuftete closed 1 year ago

oeuftete commented 1 year ago

For the moment, this isn't generating the .puz for the crossword test.

Fixes: https://github.com/jpd236/CrosswordScraper/issues/38

I thought I'd give this a shot, but I'm missing some subtleties here about nullability, I think.

jpd236 commented 1 year ago

See note in https://github.com/jpd236/CrosswordScraper/issues/38#issuecomment-1756092806 - since the byline is actually still present, just in a different field, I'd prefer to first read from that new field before falling back to an empty byline. But thank you for identifying the issue and taking a pass at a fix!