search

jpdillingham / Soulseek.NET

A .NET Standard client library for the Soulseek network.
GNU General Public License v3.0
175 stars 24 forks source link

Separate EventArgs from delegates #735

Closed jpdillingham closed 2 years ago

jpdillingham commented 2 years ago

This PR swaps EventArgs subclasses used in option delegates for tuples of the same shape. This shouldn't be too disruptive to consumers since the same properties exist, but it will be a breaking change.

Closes #726

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #735 (91fbc0d) into master (19dfa95) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         178      178           
  Lines        6083     6083           
  Branches      913      913           
=======================================
  Hits         6065     6065           
  Misses          8        8           
  Partials       10       10
Impacted Files Coverage Δ
src/Options/BrowseOptions.cs 100.00% <100.00%> (ø)
src/Options/SearchOptions.cs 100.00% <100.00%> (ø)
src/Options/TransferOptions.cs 100.00% <100.00%> (ø)
src/SoulseekClient.cs 99.17% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more