jpdillingham commented 2 years ago

This PR makes a number of small tweaks to avoid lambda expressions in property getters, and instead sets those values in the constructor where possible.

Also closes #741

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

99.0% Coverage
0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #743 (1889704) into master (f702926) will decrease coverage by 0.03%. The diff coverage is 98.57%.

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   99.70%   99.67%   -0.04%     
==========================================
  Files         178      178              
  Lines        6086     6117      +31     
  Branches      913      916       +3     
==========================================
+ Hits         6068     6097      +29     
- Misses          8        9       +1     
- Partials       10       11       +1

Impacted Files	Coverage Δ
src/Network/MessageConnection.cs	`97.05% <50.00%> (-2.95%)`	:arrow_down:
src/Common/WaitKey.cs	`100.00% <100.00%> (ø)`
src/Diagnostics/DiagnosticEventArgs.cs	`100.00% <100.00%> (ø)`
src/EventArgs/BrowseProgressUpdatedEventArgs.cs	`100.00% <100.00%> (ø)`
src/EventArgs/DistributedParentEventArgs.cs	`100.00% <100.00%> (ø)`
...ventArgs/PrivilegeNotificationReceivedEventArgs.cs	`100.00% <100.00%> (ø)`
src/File.cs	`100.00% <100.00%> (ø)`
...rc/Messaging/Handlers/DistributedMessageHandler.cs	`100.00% <100.00%> (ø)`
...Messaging/Messages/Server/ConnectToPeerResponse.cs	`100.00% <100.00%> (ø)`
src/Messaging/Messages/Server/LoginRequest.cs	`100.00% <100.00%> (ø)`
... and 9 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

jpdillingham / Soulseek.NET

Tweak property getters, don't log distributed pings and pongs #743

Codecov Report