search

jpdillingham / Soulseek.NET

A .NET Standard client library for the Soulseek network.
GNU General Public License v3.0
173 stars 24 forks source link

Change default string encoding to UTF-8, log a warning when falling back to ISO-8859-1 #778

Closed jpdillingham closed 1 year ago

jpdillingham commented 1 year ago

Related to #777

codecov[bot] commented 1 year ago

Codecov Report

Merging #778 (3ce3249) into master (50882a0) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #778   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files         180      182    +2     
  Lines        6176     6202   +26     
  Branches      934      942    +8     
=======================================
+ Hits         6138     6164   +26     
  Misses         21       21           
  Partials       17       17
Impacted Files Coverage Δ
src/CharacterEncoding.cs 100.00% <100.00%> (ø)
src/Diagnostics/GlobalDiagnostic.cs 100.00% <100.00%> (ø)
src/Messaging/MessageBuilder.cs 100.00% <100.00%> (ø)
src/Messaging/MessageReader.cs 100.00% <100.00%> (ø)
src/SoulseekClient.cs 99.31% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication