jpdillingham / Soulseek.NET

A .NET Standard client library for the Soulseek network.
GNU General Public License v3.0
173 stars 24 forks source link

Fix bug in exception message when failing DNS resolution #792

Closed jpdillingham closed 10 months ago

jpdillingham commented 10 months ago

A few people created issues in the slskd repo during the recent DNS outage of the Soulseek server(s); part of the issue is that the exception message they were seeing didn't make a lot of sense:

Soulseek.AddressException: Failed to resolve address '': Resource temporarily unavailable

Had this said Failed to resolve address 'vps.slsknet.org' as intended, this likely wouldn't have been an issue. This PR fixes the message.

codecov[bot] commented 10 months ago

Codecov Report

Merging #792 (e82a681) into master (1277bcb) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files         182      182           
  Lines        6202     6202           
  Branches      934      934           
=======================================
  Hits         6164     6164           
  Misses         21       21           
  Partials       17       17           
Files Coverage Δ
src/SoulseekClient.cs 99.31% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here