search

jpdillingham / Soulseek.NET

A .NET Standard client library for the Soulseek network.
GNU General Public License v3.0
173 stars 24 forks source link

Allow binding listener to specific IP #794

Closed jpdillingham closed 9 months ago

jpdillingham commented 10 months ago

Closes #780

There's not an easy way to unit test this with anything other than 0.0.0.0 and 127.0.0.1 (IPAddress.Any and IPAddress.Loopback, respectively). I tested locally.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e82a681) 99.38% compared to head (0c3c76c) 99.38%. Report is 13 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #794 +/- ## ======================================= Coverage 99.38% 99.38% ======================================= Files 182 182 Lines 6202 6214 +12 Branches 934 938 +4 ======================================= + Hits 6164 6176 +12 Misses 21 21 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
1.1% 1.1% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here