search

jpeddicord / askalono

A tool & library to detect open source licenses from texts
Apache License 2.0
256 stars 25 forks source link

AppVeyor: Enable symlinks before cloning #30

Closed sschuberth closed 5 years ago

sschuberth commented 5 years ago

Description of changes:

This way we can get rid of the clean-up / reset performed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jpeddicord commented 5 years ago

Ah! That's much cleaner. For some reason the AppVeyor check has stalled out and is preventing me from merging. I'll come back to this in a couple hours and see if that's cleared out; if it hasn't I'll remove that from the protected branch options and merge.

Thanks for the change!

sschuberth commented 5 years ago

I just did a dummy amend to force retriggering the builds.

jpeddicord commented 5 years ago

I have a hunch that AppVeyor isn't configured to run on pull requests, since it hasn't started anything on the build account.. I'll remove that from branch protection rules for now and diagnose separately.

jpeddicord commented 5 years ago

This actually failed to build in the end (same symlink issue):

https://ci.appveyor.com/project/jpeddicord/askalono/build/master-4

I recall strangeness here last time it happened. Something weird when running git commands before the repo was cloned.

sschuberth commented 5 years ago

Ah, right, I now recall that core.symlinks defaults to true anyway, but clone will probe the underlying file systems and eventually change the default. I have another idea what to try out, and will do so in my fork first now.

sschuberth commented 5 years ago

So that was an interesting case to debug, but I finally found out what's going on, see the commit message of PR https://github.com/amzn/askalono/pull/31.