search

jpeddicord / askalono

A tool & library to detect open source licenses from texts
Apache License 2.0
256 stars 25 forks source link

Please include the license file into the askalono-cli crate #38

Closed eclipseo closed 4 years ago

eclipseo commented 5 years ago

It would help for packaging. Also the README and NOTICE included with the cli would help too.

jpeddicord commented 5 years ago

Ah! Good catch. This will probably be best served by a wrapper script to copy those into the CLI crate before publishing.

ignatenkobrain commented 5 years ago

it is much easier than that. Just create symlinks.

jpeddicord commented 5 years ago

Symlinks work if Cargo will dereference them when packaging. Does it?

Looking at https://github.com/rust-lang/cargo/issues/2748 it doesn't seem to have any good symlink behavior.

jpeddicord commented 4 years ago

I forgot to do this in 0.4.0 just now, but I see that at least today cargo does deref symlinks! So I've added these in and will get that out in 0.4.1 (I intend on some faster release cadence, so hopefully real soon.)

jpeddicord commented 4 years ago

These were included in 0.4.1 as of last month. Thanks for reporting!