search

jpeddicord / askalono

A tool & library to detect open source licenses from texts
Apache License 2.0
255 stars 25 forks source link

replace `failure` crate with `anyhow` #69

Closed hdhoang closed 2 years ago

hdhoang commented 2 years ago

Issue #, if available: closes #67

Description of changes: There's a call of err_msg with no formatting, which I replaced with format_err! for consistency with other imports. Perhaps we can add result.score there?

The lambda dep-tree still pulls in failure.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Please apply label "hacktoberfest-accepted" if you approve, thanks in advance!

jpeddicord commented 2 years ago

Thanks again! I'll try to get a release ready real soon.

o2sh commented 2 years ago

Hi @jpeddicord :wave: Do you have an idea of when we can expect this new release? I would like to close o2sh/onefetch#432 for our next version.

Thanks again for the great work on askalono :100:

jpeddicord commented 2 years ago

Starting that now; apologies for the delay. I'm aiming to get this done and released by tomorrow -- updating the SPDX dataset and doing some other minor maintenance as well.

jpeddicord commented 2 years ago

@o2sh Done! Crates.io has 0.4.4 of both askalono and askalono-cli. I'm going to keep cleaning more up today and might release 0.4.5 with more dependency cleanup (askalono really has too many dependencies), but for now this should get you going.