search

jpeddicord / askalono

A tool & library to detect open source licenses from texts
Apache License 2.0
256 stars 25 forks source link

Too many panics/unwraps in the wrong places #9

Closed jpeddicord closed 6 years ago

jpeddicord commented 6 years ago

I'd like to remove most .unwrap calls where reasonable. The code doesn't crash* in normal operation, but when given invalid input it happily panics. That's bad.

*that I know of

jpeddicord commented 6 years ago

I'm a lot more comfortable with the state of things now. There are still a bunch of unwraps, but they're used in places where, barring future logic errors, a value will always be present.

Will re-evaluate in the future.