jpellerin / emacs-crystal-mode

A minimal crystal mode for emacs, based on ruby-mode (of course)
GNU General Public License v3.0
23 stars 13 forks source link

Won't this be updated anymore? #14

Open tbrand opened 7 years ago

tbrand commented 7 years ago

I love emacs and crystal. I really disappointed when I knew this repository is not updated recently since there are still bugs especially when I write macros.

Here is a wrong indenting pattern which I faced.

{% if ok = true %}
{{ok}} # should be indented
{% end %}
{% if true %}
  func0
{% else %}
func1 # should be indented
{% end %}
{% if true %}
{% end %}
  {% if true %} # wrong indenting
  {% end %}

It seems that @dotmilk and @TechMagister are still developing in forked repository. But the bugs above are still remaining.

Have anyone solved this bugs? (The lisp syntax is not readable for me...)

rocky commented 7 years ago

Well, I suppose you could fork the code and make improvements. After all, that part of what github is about.

tbrand commented 7 years ago

I will struggle with the elisp.

rocky commented 7 years ago

That's the spirit!

TechMagister commented 7 years ago

@tbrand I found a way to fix it, but elisp is not my favorite language, so give me feedback if you find some bugs :)

tbrand commented 7 years ago

Thanks a lot @TechMagister !!:tada: I will use it!

This works very fine! Thanks again! :)

RX14 commented 7 years ago

I think a problem here is everyone forking stuff and working independently. Merging upstream isn't working so we need to agree on another collective upstream. https://github.com/dotmilk/emacs-crystal-mode seems like a good candidate.

TechMagister commented 7 years ago

Good idea ! @dotmilk what do you think ?

tbrand commented 7 years ago

Agree! Additionally, may be the repository should be detached from the original. Because we cannot post issues and PRs to forked repository.

RX14 commented 7 years ago

@tbrand You can turn on issues for a fork, and you can always send PRs.

dotmilk commented 7 years ago

I have turned on issues on my fork

RX14 commented 7 years ago

Make sure to watch @dotmilk's repo if you're interested in fixing bugs.

tbrand commented 7 years ago

I got it! Thanks for all!