jpemartins / speex.js

Speex codec in Javascript. Mirror from https://code.ua.pt/projects/speex-js
214 stars 63 forks source link

Corrupt .ogg files on demo site? #12

Closed WillCodeCo closed 10 years ago

WillCodeCo commented 10 years ago

I cannot play the sample .ogg files on the http://www.jpemartins.com/speex.js/ demo site.

It appears they are corrupted?

I also have issues when trying to play the oggs when they are downloaded onto my system, in VLC player.

jpemartins commented 10 years ago

In Chrome and Firefox (Windows/Linux/OS X) it plays fine according to what I tested. On mobile Firefox also works fine tough some troubles with Chrome. Which browser are you using?

For VLC that behaviour is expected. There is a field called granule_pos that is not updated correctly. This field describes the number of samples per frame. It this is correct the Ogg decoder might ignore which is the case in the opensource libogg.

WillCodeCo commented 10 years ago

I experience issues both on Chrome and Firefox running on Ubuntu 12.04

When I click on one of the .ogg links in Firefox I get 'Video can't be played because the file is corrupt'

In chrome the standard audio player thingo appears but the play button does nothing.

I have confirmed that I can play ' http://upload.wikimedia.org/wikipedia/en/4/45/ACDC_-_Back_In_Black-sample.ogg' in both browsers with no problems.

On Mon, Jun 30, 2014 at 10:50 AM, João Martins notifications@github.com wrote:

In Chrome and Firefox (Windows/Linux/OS X) it plays fine according to what I tested. On mobile Firefox also works fine tough some troubles with Chrome. Which browser are you using?

For VLC that behaviour is expected. There is a field called granule_pos that is not updated correctly. This field describes the number of samples per frame. It this is correct the Ogg decoder might ignore which is the case in the opensource libogg.

— Reply to this email directly or view it on GitHub https://github.com/jpemartins/speex.js/issues/12#issuecomment-47503516.

jpemartins commented 10 years ago

Yeah that's normal. No browser supports spee when using the default player. That's the reason why we need speex.js. FYI ogg is a container that supports various codecs like CELP, opus and speex for different kinds of streaming.

I thought you meant if you put these demo files inside the decode form in the demo page. If you do so you will hear some sound. Note that these samples files are taken from Speex oficial website.

WillCodeCo commented 10 years ago

Sorry for wasting your time, I knew I must have been missing something! cheers

On Mon, Jun 30, 2014 at 11:30 AM, João Martins notifications@github.com wrote:

Yeah that's normal. No browser supports spee when using the default player. That's the reason why we need speex.js. FYI ogg is a container that supports various codecs like CELP, opus and speex for different kinds of streaming.

I thought you meant if you put these demo files inside the decode form in the demo page. If you do so you will hear some sound. Note that these samples files are taken from Speex oficial website.

— Reply to this email directly or view it on GitHub https://github.com/jpemartins/speex.js/issues/12#issuecomment-47506570.

jpemartins commented 10 years ago

No problem!

Try it out and let me know of any issues :)

WillCodeCo commented 10 years ago

I was playing around to see how well it could handle larger files. This file seemed to break it

http://www.filedropper.com/f2lcapam

I wonder if its just a limitation of it being executed in the browser - it hits a 'Maximum call stack size exceeded' error

The wav file is 1.3mb 16Khz (from http://www.cstr.ed.ac.uk/projects/eustace/down/eustace_wav_f2.zip) seen at http://www.cstr.ed.ac.uk/projects/eustace/download.html

Though it seems to work pretty nicely for the smaller audio files, and I really shouldnt be recording that much sound anyway.

cheers

On Mon, Jun 30, 2014 at 11:42 AM, João Martins notifications@github.com wrote:

Closed #12 https://github.com/jpemartins/speex.js/issues/12.

— Reply to this email directly or view it on GitHub https://github.com/jpemartins/speex.js/issues/12#event-136408957.

jpemartins commented 10 years ago

That issue was reported in #7. That's why you are getting those errors.

When I created speex.js, the usecase was VoIP applications. The file support is still a bit naive :)