/vanish support for join and leave messages [WIP]

jpenilla / AnnouncerPlus

Announcement and Join/Quit message plugin with support for permissions. Supports Hex colors, gradients, Achievements, Titles, Action Bars, and more. Uses MiniMessage for text formatting

https://www.spigotmc.org/resources/announcer-plus.81005/

MIT License

71 stars 13 forks source link

/vanish support for join and leave messages [WIP] #176

Closed NotAlexNoyle closed 3 months ago

NotAlexNoyle commented 1 year ago

Using the main branch of AnnouncerPlus, I was getting duplicate join and leave messages when using /vanish. So I made an attempt to fix the issue. The fix resulted in a new bug where the username is blank during the leave message. I don't really understand Kotlin well enough to figure out what is wrong with it. If someone could pick up this PR and finish it, I would be very appreciative.

There was an attempt (TM).

jpenilla commented 1 year ago

Do you have reproduction steps for the duplicate messages issue?

jpenilla commented 3 months ago

Closing due to lack of response