jpenilla / MiniMOTD

Minecraft server/proxy plugin to set the server list MOTD using MiniMessage for formatting, supporting RGB colors.
https://modrinth.com/plugin/minimotd
MIT License
286 stars 32 forks source link

[Feature Request] Take into account Minecraft version for update checks on Fabric #135

Open tacogerbil opened 1 year ago

tacogerbil commented 1 year ago

Describe the bug Using MiniMOTD on Fabric 1.19.2 (Using it for Cobblemon) and the log is stating there is an update. When I go to the update sources thay all have the updates for Fabric marked as being 1.19.4.

[13:58:02] [ForkJoinPool.commonPool-worker-3/INFO]: There is an update available for MiniMOTD! [13:58:02] [ForkJoinPool.commonPool-worker-3/INFO]: This server is running version v2.0.9, which is 3 versions outdated. [13:58:02] [ForkJoinPool.commonPool-worker-3/INFO]: Download the latest version, v2.0.12 from GitHub at the link below:

To Reproduce Steps to reproduce the behavior:

  1. Boot up the server and watch the log.

Expected behavior The mod wouldn't tell you that there is a new release for the version you are currently lrunning.

Screenshots If applicable, add screenshots to help explain your problem.

Server Software and Version:

Additional context N/A

jpenilla commented 1 year ago

The same thing applies as with TabTPS: https://github.com/jpenilla/TabTPS/issues/30#issuecomment-986148415

salocinyeet commented 2 months ago

I am running 1.20.1 Fabric

I have this same issue

Screenshot 2024-06-25 at 02 37 00

After the update

Screenshot 2024-06-25 at 02 37 29