jpenilla / MiniMOTD

Minecraft server/proxy plugin to set the server list MOTD using MiniMessage for formatting, supporting RGB colors.
https://modrinth.com/plugin/minimotd
MIT License
276 stars 31 forks source link

Remove config writeback comments #177

Open natopotato390 opened 5 months ago

natopotato390 commented 5 months ago

Using release 2.1.0 on PaperMC

Great plugin, does what I need. One small annoyance,

It would be nice to be able to put multiple motd's in the config like this:

icon-enabled=false
motds=[
    {
        line1="SandCraft"
        line2="This is a motd!"
    },
    {
        line1="SandCraft"
        line2="This is another motd!"
    }
]

...without it being changed by the plugin on server startup to this:

icon-enabled=false
motds=[
    {
        # Set the icon to use with this MOTD
        #  Either use 'random' to randomly choose an icon, or use the name
        #  of a file in the icons folder (excluding the '.png' extension)
        #    ex: icon="myIconFile"
        icon=random
        line1="SandCraft"
        line2="This is a motd!"
    },
    {
        # Set the icon to use with this MOTD
        #  Either use 'random' to randomly choose an icon, or use the name
        #  of a file in the icons folder (excluding the '.png' extension)
        #    ex: icon="myIconFile"
        icon=random
        line1="SandCraft"
        line2="This is another motd!"
    }
]

When your server has a lot of different motd's it becomes a hassle to go back in later and edit things with this wall of text between EVERY message.

Any of the values (like icon= or line2=) should also be able to be omitted without it being added back in automatically.

ltjessem commented 5 months ago

Wholeheartedly agree. In addition to this, imagine how happy I was to have backups when I commented out all my MOTDs temporarily, and the plugin straight up deleted the commented out lines. I'd label this a straight up bug.