jpenilla / chesscraft

Paper plugin adding in-world chess matches against players and chess engines (CPUs) to Minecraft
https://modrinth.com/plugin/chesscraft
Apache License 2.0
19 stars 2 forks source link

Feature request: Configuration #11

Closed SlimeDog closed 1 year ago

SlimeDog commented 1 year ago

I manage plugin update-checking -- we have a home-grown update-checker -- and configuration and message content precisely. For every release, I compare the new configuration with the previous (saved) to identify changes and make necessary adjustments (for example, I disable update-checking -- not relevant for ChessCraft, but bear with me -- and remove formatting codes from messages). It is very helpful if the default configuration and messages are included in the JAR. Otherwise, I have to jump through hoops to make the necessary comparisons. So, several requests:

jpenilla commented 1 year ago

Separate messages into messages.yml

Having the messages in the main config was never intended to be a long-term solution. Eventually, they will be separate but I haven't decided exactly what the impl will be yet.

Include config.yml and messages.yml in the JAR.

Depending on how I implement messages in the long run they might be in the jar. Configs being in the jar is probably not going to happen though.

Configuration includes...

I'm not sure what you mean with the rest here, are you suggesting I should hardcode values for the provided resource pack instead of allowing customization?

For future reference, please try to keep issues focused on one topic. Closing this as it's quite unfocused and not really productive for the project.