search

jpenilla / squaremap

squaremap is a minimalistic and lightweight world map viewer for Minecraft servers, using the vanilla map rendering style
https://modrinth.com/plugin/squaremap
Other
332 stars 40 forks source link

Feedback wanted: show_x url params persist when copying link #319

Open jpenilla opened 4 hours ago

jpenilla commented 4 hours ago

When using the link ui to copy a link, the params for hiding and showing elements are persisted. Not 100% sure if this is desirable, there is valid reasoning for both ways. Should we add another parameter to control this, keep it, or revert it (not persist)? Please comment if you have thoughts on this.

see #315

Chucky3920 commented 3 hours ago

I think it should persist the show_x stuff, because its pretty annoying typing it out everytime + right now you type it out manually

jpenilla commented 3 hours ago

The reason I was thinking it shouldn't persist would be if someone disabled all the UI elements except for the link button, they may want to use it as a way to get a link to the full map as opposed to the iframe view with elements disabled. Since you think we should keep the persistence, maybe a separate parameter to control this would be best.

Chucky3920 commented 3 hours ago

Sure, I just needed this for my iframe because my iframe is tiny and the sidebar and stuff just clutters the screen when it's 150x150px