search

jpenney / use-google-libraries

WordPress plugin: Allows your site to use common javascript libraries from Google's AJAX Libraries CDN, rather than from WordPress's own copies.
10 stars 4 forks source link

php strict #1

Closed cfoellmann closed 10 years ago

cfoellmann commented 11 years ago

The current version throws a PHP STRICT Redefining already defined constructor for class JCP_UseGoogleLibraries on line 123 in file /var/www/clients/client1/web2/web/wp-content/plugins/use-google-libraries/use-google-libraries.php

This strict is not thrown on every request to wp. That could make debugging this difficult.

My environment is PHP 5.4.x

@jpenney I will send you a pull request with a configuration for travis-ci.org

cfoellmann commented 11 years ago

This seems to be solved by removing the PHP 4 contructor:

/**
 * PHP 4 Compatible Constructor
 */
function JCP_UseGoogleLibraries() {$this->__construct();}

Do not think this is needed anymore since WP requires PHP 5.2.4 or greater anyway.