jperasmus / docsify-copy-code

A docsify plugin that copies Markdown code block to your clipboard
MIT License
100 stars 73 forks source link

Fix multiple Vue instance compatibility. Fix visibility on focus. #10

Closed jhildenbiddle closed 6 years ago

jhildenbiddle commented 6 years ago

Displays button on focus. Addresses hidden focus indicator when copy button is focused via keyboard navigation (tab key).

jhildenbiddle commented 6 years ago

Hey @jperasmus.

Looks like you granted me the ability to merge PRs (thanks!), but I wanted to run this by you before doing so. Even if I merged the PR myself, I don't believe I'm setup to push a docsify-copy-code release to NPM.

Thanks!

jperasmus commented 6 years ago

Hey @jhildenbiddle,

Thanks for taking the time to PR this fix. I've now added you as a collaborator for the package on NPM so you can publish new versions.

jhildenbiddle commented 6 years ago

Thanks for adding me as a collaborator, @jperasmus. Very kind of you.

I'm happy to collaborate whichever way works best for you. I'd propose it's best for you to continue handling merges and publishing new versions to NPM. This way you never have to wonder if a release is going out without you knowing about it (I would never do that, btw). I'm happy to dive in if a critical fix needs to be implemented and published, but barring that I'm happy to take on a support role.

How does that sound to you?

jperasmus commented 6 years ago

It's a pleasure. I am quite happy with you merging PR's and publishing to NPM. You've already been a great help on this repo and I've seen the work you've done on some of your own repo's, so I trust your judgement.

I also do not always get time to attend to this repo and support issues that might pop up as quickly as I would like, so it helps me as well if there are other people helping according to their capacity.

jhildenbiddle commented 6 years ago

Sounds good. Happy to handle the merge and publishing a new version.

Thanks again, @jperasmus. Really enjoy working with you. 😄