how about i18n support?

jperasmus / docsify-copy-code

A docsify plugin that copies Markdown code block to your clipboard

MIT License

99 stars 72 forks source link

how about i18n support? #13

Closed wizicer closed 5 years ago

wizicer commented 5 years ago

It would be great to know this plugin supports i18n. Any idea?

jperasmus commented 5 years ago

Hi @wizicer, thanks for reaching out. It is not currently something we were planning to add, but we are open to the idea. Would you like to create a PR?

wizicer commented 5 years ago

I'm new to docsify, not familiar with its API so far. Maybe after I have migrated my programming book to docsify, I'll create the PR. BTW, thanks for your great code.

jhildenbiddle commented 5 years ago

@wizicer --

Fixed in 2.1.0. See updated README for details.

wizicer commented 5 years ago

@jhildenbiddle thanks, just tried the code, it works like a charm. BTW: learned a lot from your PR -- complete and intuitive simple, thanks again.

jhildenbiddle commented 5 years ago

Happy to help, @wizicer!