search

jperasmus / docsify-copy-code

A docsify plugin that copies Markdown code block to your clipboard
MIT License
100 stars 73 forks source link

Updated script URLs #6

Closed jhildenbiddle closed 6 years ago

jhildenbiddle commented 6 years ago

Just tested 2.x. The code changes work as expected, however...

The previous instructions explicitly linked to the index.js:

<script src="//unpkg.com/docsify-copy-code/index.js"></script>

Since the index was moved to /src, this file no longer exists. The correct URL--which lets unpkg.com redirect based on the unpkg values in package.json--is actually:

<!-- Let unpkg redirect, based on "unpkg" value in package.json -->
<script src="//unpkg.com/docsify-copy-code"></script>

I didn't realize that the previous instructions linked directly to index.js, so I apologize for the oversight 🤦‍♂️ . Happy to help mitigate this if necessary.

In the meantime, I've updated the README to link to the correct URL and provided a version-specific URL.

Thanks @jperasmus.

jperasmus commented 6 years ago

I'm happy with it like this since we are bumping to a new major version, breaking changes are okay. People that are already using version 1 can continue doing so if they prefer.