search

jperasmus / docsify-copy-code

A docsify plugin that copies Markdown code block to your clipboard
MIT License
99 stars 71 forks source link

Proper keyboard focus boundary is not visible on the ‘Copy to clipboard’ button. #71

Open msftedad opened 7 months ago

msftedad commented 7 months ago

Test Environment: OS: Windows11 OS Version: 23H2 (Build 25905.1000) Browser: Edge Dev (Version 117.0.2007.0 (Official build) dev (64-bit)) URL: PWABuilder - Packaging for the Google Play Store Screen reader: Narrator

Steps to reproduce

  1. Open the URL: PWABuilder - Packaging for the Google Play Store in browser.
  2. Navigate to ‘Copy to clipboard’ button through tab key.
  3. Observe the issue.

Current behaviour Keyboard focus boundary is not visible on the ‘Copy to clipboard’ button present at the page.

Expected behaviour Proper keyboard focus boundary should be visible on the ‘Copy to clipboard’ button.

Attachments:

Proper keyboard focus boundary is not visible on the ‘Copy to clipboard’ button1 (1) Proper keyboard focus boundary is not visible on the ‘Copy to clipboard’ button (1)
jhildenbiddle commented 7 months ago

This appears to be a theme-specific issue. Please provide details on either the theme or OS-level settings used that produce this error.

msftedad commented 5 months ago

Verified this issue is still reproduce on latest environment

Pre-requisite: Open System Settings. Select 'Accessibility' tab. Select 'Color Contrast theme'. In the 'Color Contrast theme' combo box select 'Aquatic/Desert' theme. Test Environment: OS Build: Windows 11 version 23H2 (26040.1000) Edge Browser: Version 122.0.2365.3(Official build) dev (64-bit) URL: PWA Starter - Routing and Navigation (pwabuilder.com) copy to clipboard

jperasmus commented 4 months ago

@msftedad Please contribute a PR for this fix. I would be more than happy to review and publish.

msftedad commented 2 weeks ago

@jperasmus, Can you please guide on which we need to add PR? image

jperasmus commented 2 weeks ago

Hi @msftedad You can PR against the master branch, thanks.

msftedad commented 1 week ago

@jperasmus, we are unable to create PR for this issue. Could you please help us on creating the PR?

jperasmus commented 1 week ago

@msftedad Are you running into permission issues or what is the problem you're experiencing? If it is permission issues, you are likely trying to push directly to a branch on this repo. That won't work. What you should do instead is fork this repo and then create the PR from your branch on the fork to the master branch of this repo.