search

jperelli / Redmine-Periodic-Task

A redmine plugin that lets you schedule an issue to fire every x days/weeks/months
MIT License
72 stars 50 forks source link

The plugin does not check, if the project still exists #76

Open s-andy opened 6 years ago

s-andy commented 6 years ago

When a project with periodic task is removed, its tasks are not. This causes crash of the rake task at the line:

https://github.com/jperelli/Redmine-Periodic-Task/blob/7c52e0c153c06ab5277b8211cc238f9afe31507a/lib/scheduled_tasks_checker.rb#L34

Here, #save executes validations and validations attempt to access the project, which does not exist any longer. The exact error message is:

rake aborted!
NoMethodError: undefined method `assignable_users' for nil:NilClass
/opt/bitnami/apps/redmine/htdocs/app/models/issue.rb:928:in `assignable_users'
/opt/bitnami/apps/redmine/htdocs/app/models/issue.rb:729:in `validate_issue'
/opt/bitnami/apps/redmine/htdocs/plugins/periodictask/lib/scheduled_tasks_checker.rb:34:in `block in checktasks!'
/opt/bitnami/apps/redmine/htdocs/plugins/periodictask/lib/scheduled_tasks_checker.rb:4:in `checktasks!'
/opt/bitnami/apps/redmine/htdocs/plugins/periodictask/lib/tasks/periodictask.rake:11:in `block (2 levels) in <top (required)>'
Tasks: TOP => redmine:check_periodictasks
(See full trace by running task with --trace)

I believe, the plugin should be fixed, so that periodic tasks are removed with the project.

jperelli commented 6 years ago

Great catch! If you make a pull request, I'll be happy to merge it!