search

jperkin / node-openzwave

node.js interface to libopenzwave
Other
110 stars 54 forks source link

feature request: report magic numbers in addition to text #11

Closed mrose17 closed 10 years ago

mrose17 commented 10 years ago

compare:

node2: Aeon Labs, Smart Energy Switch node2: name="", type="Binary Power Switch", location=""

v.

node5: Cooper, Unknown: type=4449, id=0003 node5: name="Plug-in Dimmer", type="Multilevel Power Switch", location=""

this may seem kind of odd, but i'd really like to get the type & id that are used by openzwave to construct the product field

would you consider having the 'node ready' event also return values from

    string GetNodeManufacturerId( uint32 const _homeId, uint8 const _nodeId );
    string GetNodeProductId( uint32 const _homeId, uint8 const _nodeId );
    string GetNodeProductType( uint32 const _homeId, uint8 const _nodeId );

thanks!

/mtr

jperkin commented 10 years ago

Agreed, thanks, the strings the openzwave module was returning aren't at all useful.

Note that I've forced push the repository, as there was a bunch of things in the history that needed fixing. I know forced updates aren't great, but as yours is the only fork currently I figured I'd take the hit early. Sorry if it causes any issues merging your changes.

mrose17 commented 10 years ago

hi. no worries on the force push. i was planning on deleting my fork and re-forking it today anyway!