Option to prevent automatic close of rpio

jperkin / node-rpio

Raspberry Pi GPIO library for node.js

857 stars 123 forks source link

Option to prevent automatic close of rpio #119

Closed chriskinsman closed 4 years ago

chriskinsman commented 4 years ago

I have a case where I need to do cleanup of various rpio pins prior to shutting down rpio.

Adds a new option to prevent automatic close_on_exit. Maintains previous behavior by defaulting to true
Adds a new prototype method. exit, to shut down rpio
Updates docs

Addresses #118

chriskinsman commented 4 years ago

Can @jperkin or other contributor take a look and merge?

jperkin commented 4 years ago

Yeh I'll try to get to this soon.

chriskinsman commented 4 years ago

@jperkin sorry if bothering you but I have something blocked on this. Perhaps you could get a chance to look at this pull request?

chriskinsman commented 4 years ago

@jperkin One more ping. Have another pull request to replace WiringPI in a different project but need this pull request to land before I can submit that one. Thanks!

jperkin commented 4 years ago

Yeh sorry, I wanted to get this done over this weekend, but then had to deal with fallout from https://twitter.com/jperkin/status/1281253912717262850 instead.

jperkin commented 4 years ago

Thanks! Sorry it took a while. Merged in v2.1.3.

chriskinsman commented 4 years ago

Thanks!

Sent from my iPhone

On Jul 20, 2020, at 4:12 AM, Jonathan Perkin notifications@github.com wrote:

Thanks! Sorry it took a while. Merged in v2.1.3.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.