search

jperkin / node-rpio

Raspberry Pi GPIO library for node.js
858 stars 124 forks source link

Added support for Allwinner's H3 and H5 chips: NanoPi and Orange Pi #52

Closed lubino closed 6 years ago

lubino commented 7 years ago

Please let me know in case of any issues

jperkin commented 7 years ago

Firstly, thank you so much for working on this. It's great to know you have a working implementation. In terms of merging, I'd like to do it a bit differently and avoid having to bring in the wiringPi code as well as having a mostly duplicate backend. There are also a few stylistic issues I'd like to clean up. If you don't mind I'd like to work on this, and then get you to test ready for integration? I'll of course give you credit for the implementation. I just got back from vacation so may take a little while to catch up and start working on it, hope that's ok. Thanks!

lubino commented 7 years ago

No problem about that, I wasn't sure about rpio/npio bindings as well. I didn't want to load any unnecessary C code to nodejs in runtime, that's why I divided it per cpu. Of course, the decision or way how to style code is completely up to you, I don't mind about that at all, I just prefer one npm 'rpio' module for all boards, that is very convenient for me. When you are ready, and you would have some working branch or code for me to test, just let me know please, I'll do all test on all boards I have. Thank you too, I like your module very much. In the future I would also implement the i2c and spi part as well, not only GPIO, but right now I don't have any SPI and I2C chips to test the communication in real usage.

lubino commented 7 years ago

Any news please? Can I help you in any way?