Bugfix/issue 114 - Githubissues

dudil commented 6 years ago

Description

Following discussion on issue #114 I've fixed some minor CSS issues with main.css This changes include:

Adding the h1 font-size property
Remove redundant curled bracket
Fix typo related to one of the properties

Motivation and Context

CSS cleanup, Closes #114

How Has This Been Tested?

Hugo Version: 0.35

Browser(s): Safari

Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation, including theme.toml, accordingly.
[X] I have read the Contributing Document.

pacollins commented 6 years ago

Thanks for this. I'll review it once I return home.

Also, would you be interested in assisting clean up the unused CSS? We are about to go through that process to reduce bloat, but it seems that I am the only active user that is comfortable with CSS (or they haven't said anything haha).

On Feb 11, 2018 3:44 AM, "Dudi Levy" notifications@github.com wrote:

Description

Following discussion on issue #114 https://github.com/jpescador/hugo-future-imperfect/issues/114 I've fixed some minor CSS issues with main.css This changes include:

Adding the h1 font-size property

Remove redundant curled bracket

Fix typo related to one of the properties

Motivation and Context

CSS cleanup, Closes #114 https://github.com/jpescador/hugo-future-imperfect/issues/114 How Has This Been Tested?

Hugo Version: 0.35

Browser(s): Safari Screenshots (if appropriate): Types of changes

Bug fix (non-breaking change which fixes an issue)

New feature (non-breaking change which adds functionality)

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style https://github.com/jpescador/hugo-future-imperfect/blob/master/.github/CONTRIBUTING.md#Style-Guide of this project.

My change requires a change to the documentation https://github.com/jpescador/hugo-future-imperfect/wiki.

I have updated the documentation, including theme.toml, accordingly.

I have read the Contributing Document https://github.com/jpescador/hugo-future-imperfect/blob/master/.github/CONTRIBUTING.md .

You can view, comment on, or merge this pull request online at:

https://github.com/jpescador/hugo-future-imperfect/pull/121 Commit Summary

Remove redundent closing curled barcket

Added Property for h1 font-size

Fix property typo: -moz-transition

File Changes

M static/css/main.css https://github.com/jpescador/hugo-future-imperfect/pull/121/files#diff-0 (8)

Patch Links:

https://github.com/jpescador/hugo-future-imperfect/pull/121.patch

https://github.com/jpescador/hugo-future-imperfect/pull/121.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jpescador/hugo-future-imperfect/pull/121, or mute the thread https://github.com/notifications/unsubscribe-auth/AK1UyZTg-BBfT1JHqG06iObQv1DfjXsPks5tTqh_gaJpZM4SBQsR .