Add social link for Keybase - Githubissues

jpescador / hugo-future-imperfect

A ported theme with some extras for the Hugo static website engine

MIT License

310 stars 228 forks source link

Add social link for Keybase #133

Closed tygerbytes closed 5 years ago

tygerbytes commented 6 years ago

Description

Allows users to add Keybase as one of their social links.

How Has This Been Tested?

Added my keybase name to keybase in config .toml
Verified that it rendered correctly in the list of social icons.
Removed my keybase name from keybase in config.toml
Verified that keybase no longer appeared in the list of social icons.

Hugo Version: 0.37

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation, including theme.toml, accordingly.
[x] I have read the Contributing Document.

tygerbytes commented 6 years ago

Thanks for the quick review @pacollins. I agree, using fa-key isn't ideal. The trouble is that Font Awesome have yet to add a keybase icon.

See https://github.com/FortAwesome/Font-Awesome/issues/4095, where the recommended approach is to use fa-key for now.

A keybase icon was recently added to the fork "Fork-Awesome", but that doesn't help here unfortunately. :(

tygerbytes commented 5 years ago

Closing this pull request now that we have FontAwesome 5 and the real Keybase social icon. 🎉