jpescador / hugo-future-imperfect

A ported theme with some extras for the Hugo static website engine
MIT License
308 stars 227 forks source link

Fix: relURL missing / Issue #22 #73

Closed mharrend closed 7 years ago

mharrend commented 7 years ago

Adding relURL, so that a website laying in a subfolder is also shown properly

Issue #22 was not completly fixed

Description

Motivation and Context

If the website is not hosted at a primary domain like https://example.com/ , but instead on a subdomain like https://example.com/subdomain, some links were not resolved properly.

Further fix for issue #22

How Has This Been Tested?

Tested on my own setup:

Hugo Version: 0.30.2

Browser(s): Firefox, Chromium, Chrome

Screenshots (if appropriate):

Types of changes

Checklist:

pacollins commented 7 years ago

Welcome and thank you for your additions!

Since we are addressing url related things, can you go ahead and change the example site base url to "/"? This will comply with the new theme rules from the hugoThemes site.

mharrend commented 7 years ago

@pacollins Sorry, what do you mean with changing the example site base url to "/"?

If you mean if I have tested it with the example site sitting at "/" Yes, I did this test.

It sounds like an easy fix what you want, so maybe just do the fix by yourself?

pacollins commented 7 years ago

@mharrend I went ahead and made the edit. I avoid making changes myself to other PRs because then it gives me partial credit even though you did the work. More of a courtesy thing.

PR Approved.