Fix: rssAppearAtBottom and rssAppearAtTop usage - Githubissues

jpescador / hugo-future-imperfect

A ported theme with some extras for the Hugo static website engine

MIT License

308 stars 227 forks source link

Fix: rssAppearAtBottom and rssAppearAtTop usage #74

Closed mharrend closed 7 years ago

mharrend commented 7 years ago

rssAppearAtBottom and rssAppearAtTop defined in config.toml file but not considered in sidebar

Made sure that the config options rssAppearAtBottom and rssAppearAtTop are considered in sidebar.html

Description

Replaced deprecated check for .RSS option with check for either

.Site.Params.rssAppearAtTop
.Site.Params.rssAppearAtBottom

Motivation and Context

Fixing a bug.

How Has This Been Tested?

Tested on my own setup:

Tested with hugo server locally
Tested via a deployment to Gitlab pages with subdomain.

Hugo Version: 0.30.2

Browser(s): Firefox, Chromium, Chrome

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation, including theme.toml, accordingly.
[x] I have read the Contributing Document.

pacollins commented 7 years ago

Thanks for this catch, approved.