search

jpetazzo / dockvpn

Recipe to build an OpenVPN image for Docker
Apache License 2.0
834 stars 295 forks source link

Added ability for changing VPN subnet #41

Closed AlekseySpiridonov closed 1 year ago

AlekseySpiridonov commented 2 years ago

Added ability for changing VPN subnet for avoiding conflicts with local networks.
By default is using 192.168.255.0/24 but it can be overdid by SUBNET var.

coolOpenSourceDev commented 1 year ago

@jpetazzo Could you please review this change? I use several VPN instances and connect them to one of my routers. Without the ability to change subnets on routers, an address conflict occurs. The ability to change subnets could solve this problem.

AlekseySpiridonov commented 1 year ago

@tphillips I am sorry, but it looks like I didn't get you.

Do you suggest using only one BASH variable? And what should it be called?

Note: Right now we have the environment variable SUBNET with the default value 192.168.255. This variable can be set via the command line. In BASH script, we use the default or overridden value of the SUBNET environment variable in the VPN_SUBNET BASH variable.

1vanSmirnov commented 1 year ago

Subnet changes for VPN will be a valuable contribution. (Default subnet, in my case, is interferred with a local subnet - not convenient at all)

coolOpenSourceDev commented 1 year ago

@jpetazzo Please forgive me for the direct question, but are there any plans to review this functionality or is the repository frozen after the commit 6e9c6ea? The ability to change subnets is very important for my needs.

jpetazzo commented 1 year ago

Hi @coolOpenSourceDev ! This is a very valid question. I admit that I don't maintain these projects very thoroughly (because they were initially just meant to be proof of concepts and cool demos; and it always surprises me when I see people using this - or other stuff like pipework - extensively😅)

However I see that this is a fairly straightforward pull request, so I'm going to take a look now, maybe just reword a tiny bit the doc and ship it.

Huge thanks for @AlekseySpiridonov for the PR. I'm very sorry that it took me so long to get to that.

OK, I'm going to review+merge now, hoping I don't get interrupted in the middle 😅

jpetazzo commented 1 year ago

Done! Thanks again everyone <3

coolOpenSourceDev commented 1 year ago

Thanks a lot! I really need this change. Thank you for review.