check if the IP conflicts with other system on this network.

jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)

Apache License 2.0

4.22k stars 727 forks source link

check if the IP conflicts with other system on this network. #117

Closed int32bit closed 7 years ago

int32bit commented 9 years ago

Before we set the network, we should check if the IP conflicts with other system on this network to avoid potential danger. I just ping the address to determine whether it is currently used by others.

santosh0705 commented 9 years ago

In my view you never assign any random ip address in you environment. In cases where ICMP is disabled or system is down it can't determine.

jpetazzo commented 9 years ago

Hi,

Sorry that it took so long for me to review your change.

It is a good idea, but I think it is not robust enough, for a few reasons:

it requires the system to already have an IP address on this network;
it will not work if ICMP is disabled.

I think it would be better to use a variant of arping, what do you think?