search

jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)
Apache License 2.0
4.22k stars 727 forks source link

Check code with shellcheck #137

Closed jpetazzo closed 9 years ago

jpetazzo commented 9 years ago

I've been told about http://www.shellcheck.net/. I should run it against pipework to detect possible bad patterns.

hookenz commented 9 years ago

Ran it through and it seemed to provide some warnings. Might be a good idea to look at those. Mostly quoting variables to prevent globbing or splitting.