search

jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)
Apache License 2.0
4.21k stars 727 forks source link

fix: sh doesn't support substr syntax #215

Closed liudangyi closed 7 years ago

liudangyi commented 7 years ago

By the way, would it be better to use nsenter -un instead of ip netns exec? nsenter -un will enter both network namespace and UTS namespace, while ip netns exec only enter network namespace.

jpetazzo commented 7 years ago

Good catch! Thank you for this fix. 👍

About your nsenter question: I think that almost all systems ship with ip, but they don't all ship with nsenter ... Therefore, I prefer to stick with ip. But you have a very good point.

Thanks again for your PR!