jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)
Apache License 2.0
4.21k stars 727 forks source link

Macvlan mode #221

Closed kvaps closed 6 years ago

kvaps commented 6 years ago

Hi, this PR allows to use bridges with macvlan interfaces, and attach them directly to bridges.

hookenz commented 6 years ago

@kvaps - Why not set MACVLAN_MODE=1 set inside error that originally printed the error message that it wasn't supported, thereby making the command line option unnecessary. And the original error redundant. i.e. the mode becomes automatic.

kvaps commented 6 years ago

Hi @hookenz, Using macvlan on top of bridges is quite specific configuration. Usually better to attach macvlan device on top interface from your bridge. Maybe we need to improve error message.

kvaps commented 6 years ago

@hookenz sorry, I'm kicking nonsense :) You can't use top interface of the bridge, because it is already belongs to the bridge interface:

RTNETLINK answers: Device or resource busy
kvaps commented 6 years ago

I'll close this, becuase found better solution: https://github.com/jpetazzo/pipework/pull/227