jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)
Apache License 2.0
4.21k stars 727 forks source link

Update for usage with cgroups v2? #245

Closed sotiris-bos closed 11 months ago

sotiris-bos commented 3 years ago

A recent update broke pipework for me.

I have to manually force the system to use cgroups v1 in order for it to work.

Is there any chance you can update pipework to work with cgroups v2?

This is still a very useful tool that is essential for some of us.

jpetazzo commented 3 years ago

Hi!

I don't plan to update pipework (it was meant to be a stopgap tool before Docker supported host networking and network plugins; which was... 6-ish years ago😅) but if someone creates a fork that supports cgroups v2, I will be more than happy to link it on the front page at the top of the README, to make sure other folks find it easily.

I'm curious, though, I wonder how folks do use pipework these days?

Thank you,

sotiris-bos commented 3 years ago

I am using it to pass through SR-IOV interfaces to containers instead of exposing the host networking or running bridges.

That way I have containers with DHCP addresses from my router with their own, multi-gigabit capable interface.

Your repo did not work with SR-IOV interfaces though, some changes were needed to be made to the entrypoint script, with the help of dreamcat4 if I remember correctly.

gaby commented 3 years ago

I use it heavily for attaching containers to the OpenVSwitch bridge, without having to use docker network syntax, it's just way easier to do with pipework.

yoursunny commented 11 months ago

if someone creates a fork that supports cgroups v2, I will be more than happy to link it on the front page at the top of the README

There's a Pull Request supporting cgroups v2: https://github.com/jpetazzo/pipework/pull/249 Can @jpetazzo merge it?

jpetazzo commented 11 months ago

Merged!

(Note: I'm not using pipework myself anymore, so I merged without testing; hoping that it will be useful to others :))