jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)
Apache License 2.0
4.22k stars 727 forks source link

Try to guess the container engine in use #48

Closed gurjeet closed 9 years ago

gurjeet commented 10 years ago

... then use appropriate method to extract the container's PID.

gurjeet commented 10 years ago

Hack inspired by @cpuguy83's PR #41.

I have tested this on 0.8.1 and 0.9.0; seems to work flawlessly.

jpetazzo commented 10 years ago

Hi!

First, sorry for taking so long to review this. Next, question: is this still necessary now that we use State.Pid? (The "new" pipework probably doesn't work with "old" versions of Docker, but I can live with that...)

Let me know!

Thanks.

jpetazzo commented 9 years ago

I think we can close this, not needed anymore :-) Feel free to correct me if I'm wrong.