Various customisations; add $GUESTNAME as parameter to dhcp client request.

jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)

Apache License 2.0

4.22k stars 727 forks source link

Various customisations; add $GUESTNAME as parameter to dhcp client request. #74

Closed jimmcslim closed 10 years ago

jimmcslim commented 10 years ago

Use sh instead of bash as bash not installed in boot2docker.
Provide the value of $GUESTNAME as an argument to the DHCP client so the DHCP server can add it to DNS (if the DHCP server is also acting as a DNS server, e.g. dnsmasq).

jimmcslim commented 10 years ago

I like the idea of containers as lightweight VMs. Consequently I like pipework's ability to give docker containers their own IP address accessible from other machines on my network. I use dnsmasq as a DHCP/DNS server, so if the DHCP client used by pipework sends the container's name (added in this PR) then they are automatically added to the DNS lookup table.

jpetazzo commented 10 years ago

Thanks a lot. Both changes are great. I just found one minor typo in doc; can you update it, and then I'll merge right away?

Thanks again. I really appreciate all the contributions that you folks have brought to pipework!

jimmcslim commented 10 years ago

Done.

jpetazzo commented 10 years ago

Thanks!