search

jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)
Apache License 2.0
4.22k stars 727 forks source link

README/Code discrepency #81

Closed vanosg closed 10 years ago

vanosg commented 10 years ago

Hi,

In the readme, as example code on binding to a physical interface, you have:

pipework eth2 $(docker run -d hipache /usr/sbin/hipache) 50.19.169.157
pipework eth3 $(docker run -d hipache /usr/sbin/hipache) 107.22.140.5

However, running something similar, I get:

# ./pipework eth1 $(docker run -d -t -i --name=test2 ubuntu:14.04 /bin/bash) 192.168.10.72
The IP address should include a netmask.
Maybe you meant 192.168.10.72/24 ?

Is one of these incorrect? Thanks!

bcicen commented 10 years ago

Yes, pipework will always require a subnet mask to be given -- the readme had this left out for some reason.

jpetazzo commented 10 years ago

Solved by #82; thanks!